Attention is currently required from: Zheng Bao. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57131 )
Change subject: amdfwtool: Add support for traditional recovery ......................................................................
Patch Set 4:
(4 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127175): https://review.coreboot.org/c/coreboot/+/57131/comment/c7c7a469_1cfda03d PS4, Line 519: index ++; space prohibited before that '++' (ctx:WxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127175): https://review.coreboot.org/c/coreboot/+/57131/comment/45a03d46_aa701c95 PS4, Line 806: for (index = 0; index < count; index ++) { space prohibited before that '++' (ctx:WxB)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127175): https://review.coreboot.org/c/coreboot/+/57131/comment/ca7f5d3b_a2457191 PS4, Line 817: count ++; space prohibited before that '++' (ctx:WxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127175): https://review.coreboot.org/c/coreboot/+/57131/comment/80ffb562_9e404442 PS4, Line 1799: BUFF_OFFSET(ctx, RUN_TO_OFFSET(ctx, pspdir2->entries[etr].addr)), line over 96 characters