Attention is currently required from: Arthur Heymans, Benjamin Doron, Patrick Rudolph.
David Milosevic has posted comments on this change by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/79108?usp=email )
Change subject: mb/emulation/qemu-sbsa: Generate PPTT ACPI table
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/emulation/qemu-sbsa/pptt.c:
https://review.coreboot.org/c/coreboot/+/79108/comment/fe5d830e_f575e2b5?usp... :
PS7, Line 9: #define CACHE_NODE_FLAGS 0xd7 // everything valid except, write-policy and allocation type
: #define CLUSTER_FLAGS 0x11 // physical package, ID invalid, no thread, no leaf, identical impl.
: #define CORE_FLAGS 0x1a // no physical package, ID valid, no thread, leaf, identical impl.
:
: #define CACHE_ATTR_TYPE_DATA (0)
: #define CACHE_ATTR_TYPE_INSTRUCTION (0x1 << 2)
: #define CACHE_ATTR_TYPE_UNIFIED (0x1 << 3)
The first three definitions are rather mainboard specific. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79108?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iabeb138c1257488bcb364fe7b522f02c041745e2
Gerrit-Change-Number: 79108
Gerrit-PatchSet: 7
Gerrit-Owner: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 12 Aug 2024 21:43:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: David Milosevic
David.Milosevic@9elements.com