Saurabh Mishra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84142?usp=email )
Change subject: soc/intel/common/block/pmc: Fix compilation error with MS4V=BIT(18) ......................................................................
soc/intel/common/block/pmc: Fix compilation error with MS4V=BIT(18)
If MS4V is defined using the BIT macro such in as in BIT(18) for instance, it is replaced with (1ul << 18). When the pmc_clear_pmcon_sts_pci() function performs the binary not operation on MS4V, it turns a value fitting in 32-bit into a value requiring a 64-bit. This commit cast ~MS4V to uint32_t to resolve the following compilation error observed with pantherlake code.
Change-Id: I70be1ccba59d25af2ba85a2014232072abf2f87d Signed-off-by: Saurabh Mishra mishra.saurabh@intel.com --- M src/soc/intel/common/block/pmc/pmclib.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/84142/1
diff --git a/src/soc/intel/common/block/pmc/pmclib.c b/src/soc/intel/common/block/pmc/pmclib.c index 7650fe4..557e90e 100644 --- a/src/soc/intel/common/block/pmc/pmclib.c +++ b/src/soc/intel/common/block/pmc/pmclib.c @@ -688,7 +688,7 @@ if (!dev) return;
- pci_and_config32(dev, GEN_PMCON_A, ~MS4V); + pci_and_config32(dev, GEN_PMCON_A, (uint32_t)~MS4V); }
/*