26 Apr
2023
26 Apr
'23
5:27 p.m.
Attention is currently required from: YH Lin, Tarun Tuli, Joey Peng, Paul Menzel, Nick Vaccaro.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74727 )
Change subject: soc/intel/alderlake: Add option to disable C1E ......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/74727/comment/cf7393ce_801e67b6 PS7, Line 690: c1e Change the name to c1e_enable? And use bool for it?
--
To view, visit https://review.coreboot.org/c/coreboot/+/74727
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2d2d5d6075de25141c1d08ec18838731c63a342
Gerrit-Change-Number: 74727
Gerrit-PatchSet: 7
Gerrit-Owner: Joey Peng joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: YH Lin yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Kevin3 Yang kevin3.yang@lcfc.corp-partner.google.com
Gerrit-CC: Leo Chou leo.chou@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Attention: YH Lin yueherngl@google.com
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Joey Peng joey.peng@lcfc.corp-partner.google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Comment-Date: Thu, 27 Apr 2023 00:27:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment