Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38003 )
Change subject: mainboard/google/puff: Enable net driver on pcie ep ......................................................................
mainboard/google/puff: Enable net driver on pcie ep
Let coreboot know there is a NIC device on the end so that the mac from vpd is set at early boot.
Properly configure the link-leds in devicetree s.t. valid values are written out to the register at initialization.
Finally let the linker trim unused net driver symbols when unused in devicetree rather than being overly zealous in the Kconfig.
BUG=b:146592075 BRANCH=none TEST=Boot to kernel. Insert mac address into VPD vpd -s ethernet_mac=<address> reboot the system. Ensure we have ip address and corresponding mac address with ifconfig. Ensure ethernet controller shows up with lspci.
Change-Id: I76ce6d8a5a26842fcb2544ee96567fe0da8603b1 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/variants/puff/overridetree.cb 2 files changed, 8 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/38003/1
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 3427ced..783ec73 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -22,8 +22,8 @@ select MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE select SOC_INTEL_COMETLAKE select SYSTEM_TYPE_LAPTOP - select RT8168_GET_MAC_FROM_VPD if BOARD_GOOGLE_PUFF - select RT8168_SET_LED_MODE if BOARD_GOOGLE_PUFF + select RT8168_GET_MAC_FROM_VPD + select RT8168_SET_LED_MODE
if BOARD_GOOGLE_BASEBOARD_HATCH
diff --git a/src/mainboard/google/hatch/variants/puff/overridetree.cb b/src/mainboard/google/hatch/variants/puff/overridetree.cb index 342994d..0c6b3b0 100644 --- a/src/mainboard/google/hatch/variants/puff/overridetree.cb +++ b/src/mainboard/google/hatch/variants/puff/overridetree.cb @@ -180,7 +180,12 @@ end #I2C #4 device pci 1a.0 on end # eMMC device pci 1c.0 on end # FSP requires func0 be enabled. - device pci 1c.6 on end # RTL8111H Ethernet NIC (becomes RP1). + device pci 1c.6 on + chip drivers/net + register "customized_leds" = "0x05af" + device pci 00.0 on end + end + end # RTL8111H Ethernet NIC (becomes RP1). device pci 1e.3 off end # GSPI #1 end