Attention is currently required from: Raul Rangel, Andrey Petrov, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58986 )
Change subject: drivers/intel/fsp2_0: Add FSP_ALIGNMENT_FSP_X option
......................................................................
Patch Set 2:
(2 comments)
File src/drivers/intel/fsp2_0/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/58986/comment/7cfbd3b2_efd41b66
PS2, Line 69: alignment
Unless I missed a change in this train, shouldn't this be
`-align`
?
https://review.coreboot.org/c/coreboot/+/58986/comment/2d32c695_441e6a9d
PS2, Line 82: alignment
same?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58986
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4533f6c9d56bea6520aa3aa87dd49f2144a23850
Gerrit-Change-Number: 58986
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 05 Nov 2021 21:51:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment