Attention is currently required from: Erin Park, Kapil Porwal, Paul Menzel, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75907?usp=email )
Change subject: soc/intel/meteorlake: Set Energy Perf Bias appropriate default value. ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75907/comment/ff2ad5d7_de670822 : PS1, Line 7: soc/intel/meteorlake: Set Energy Perf Bias appropriate default value.
Maybe: Default to Balance_Powersave policy
(How is it spelled in the datasheet?)
Set EPB policy to Balance_Powersave
https://review.coreboot.org/c/coreboot/+/75907/comment/6927b02d_e7097c90 : PS1, Line 10: best PnP user experience
How is that measured? Plug and Play? Doesn’t it depend on the board?
Power and Performance
File src/include/cpu/x86/msr.h:
https://review.coreboot.org/c/coreboot/+/75907/comment/c647a748_7e74821c : PS1, Line 54: tab?