Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27483 )
Change subject: sdm845: Add SPI QUP driver
......................................................................
Patch Set 55:
(1 comment)
LGTM except for the thing that was added with the UART patch. Rebase to front?
https://review.coreboot.org/#/c/27483/55/src/soc/qualcomm/sdm845/include/soc...
File src/soc/qualcomm/sdm845/include/soc/qcom_qup_se.h:
https://review.coreboot.org/#/c/27483/55/src/soc/qualcomm/sdm845/include/soc...
PS55, Line 462: uintptr_t base_addr;
Like mentioned in the UART patch, this shouldn't be here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/27483
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35061727d5ccc550eaeb06caef4524bc4cf25b54
Gerrit-Change-Number: 27483
Gerrit-PatchSet: 55
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mukesh Savaliya
msavaliy@qualcomm.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Vin Kamath
vink@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Akash Asthana
akashast@qualcomm.corp-partner.google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 25 Jun 2019 00:37:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment