Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48495 )
Change subject: mb/google/volteer: Update drobit device tree
......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48495/8/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/drobit/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48495/8/src/mainboard/google/voltee...
PS8, Line 100: 15000
`51000`, see CB:48292
Done
https://review.coreboot.org/c/coreboot/+/48495/8/src/mainboard/google/voltee...
PS8, Line 160: EDGE
LEVEL should be correct, I2C HID specification requires LEVEL triggered interrupts
Done
https://review.coreboot.org/c/coreboot/+/48495/8/src/mainboard/google/voltee...
PS8, Line 189: end
: device ref pmc hidden
Please double check if you need to add a setting similar to this: https://chromium-review. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48495
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I48a3024df4270b111b90c4fb56847aad6e65bfa1
Gerrit-Change-Number: 48495
Gerrit-PatchSet: 10
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Mon, 21 Dec 2020 07:06:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Zhuohao Lee
zhuohao@chromium.org
Gerrit-MessageType: comment