Attention is currently required from: Joey Peng, Paul Menzel, Marco Chen.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56380 )
Change subject: mb/google/octopus/var/phaser: Change IRQ trigger method to level
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56380/comment/eb01f8e3_d447c259
PS4, Line 14:
Is that commit 3b879f46b49b756b4f6e851d97677a821e11ce1d?
The commit above is for G2Touch not for Elan so might not be relevant. Partners mentioned that the original Elan section here was copied from reference design and they never build product with Elan touchscreen before.
And the feedback from vendor side mentioned, level or edge triggering should be all workable but level would be recommended from vendor side.
Patchset:
PS4:
Hi Joey, please address comments from reviewer - Paul. Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56380
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44ee779242779c78ceafdddd34dca2571e714dd3
Gerrit-Change-Number: 56380
Gerrit-PatchSet: 4
Gerrit-Owner: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alec Wang
alec.wang@lcfc.corp-partner.google.com
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Marco Chen
marcochen@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Attention: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Marco Chen
marcochen@chromium.org
Gerrit-Comment-Date: Wed, 11 Aug 2021 11:40:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment