Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46442 )
Change subject: mb/google/kukui: change Jacuzzi followers LCMID to fixed value ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46442/10/src/mainboard/google/kukui... File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/c/coreboot/+/46442/10/src/mainboard/google/kukui... PS10, Line 82: default 0x1 if BOARD_GOOGLE_JUNIPER || BOARD_GOOGLE_KAPPA || BOARD_GOOGLE_DAMU || BOARD_GOOGLE_BURNET || BOARD_GOOGLE_ESCHE
Sorry, but now this line seems to be too long. […]
Done
https://review.coreboot.org/c/coreboot/+/46442/11/src/mainboard/google/kukui... File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/c/coreboot/+/46442/11/src/mainboard/google/kukui... PS11, Line 186: / : ui I prefer to keep one blank line between this commend and sku_id, because this is NOT the function-comment for sku_id; it's explaining for functions below.