Attention is currently required from: Jason Glenesk, Nico Huber, Marshall Dawson, Julius Werner, Kyösti Mälkki, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59020 )
Change subject: treewide: Remove unused spinlock functions ......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/psp_verstage/include/arch/smp/spinlock.h:
https://review.coreboot.org/c/coreboot/+/59020/comment/db7eeebb_53994ae3 PS2, Line 8: #define spin_unlock(lock) do {} while (0)
Martin, Furquan and Aaron are no longer working on firmware. […]
Just FYI, the following diff allows the psp_verstage spinlock.h to be removed:
diff --git a/src/drivers/pc80/rtc/Makefile.inc b/src/drivers/pc80/rtc/Makefile.inc index 5f6055e872bc..12aeb3724d86 100644 --- a/src/drivers/pc80/rtc/Makefile.inc +++ b/src/drivers/pc80/rtc/Makefile.inc @@ -8,7 +8,14 @@ smm-$(CONFIG_DRIVERS_MC146818) += mc146818rtc.c all-$(CONFIG_USE_OPTION_TABLE) += option.c smm-$(CONFIG_USE_OPTION_TABLE) += option.c
-all-$(CONFIG_CMOS_POST) += post.c +ifeq ($(CONFIG_CMOS_POST),y) +bootblock-y += post.c +verstage_x86-y += post.c +romstage-y += post.c +postcar-y += post.c +ramstage-y += post.c +smm-y += post.c +endif
ifeq ($(CONFIG_USE_OPTION_TABLE),y) cbfs-files-$(CONFIG_HAVE_CMOS_DEFAULT) += cmos.default
---
The patch isn't correct though since there is no reason post.c shouldn't work in psp verstage.