Attention is currently required from: Alexander Couzens, Valentyn Sudomyr.
Paul Menzel has posted comments on this change by Valentyn Sudomyr. ( https://review.coreboot.org/c/coreboot/+/83764?usp=email )
Change subject: mb/lenovo/t520: Add USB port config into devicetree ......................................................................
Patch Set 2: Code-Review+1
(5 comments)
Patchset:
PS2: Welcome to coreboot!
Commit Message:
https://review.coreboot.org/c/coreboot/+/83764/comment/943277cd_2812fcbe?usp... : PS2, Line 2: PuFF1k If possible, it’d be great if you used your full name.
https://review.coreboot.org/c/coreboot/+/83764/comment/0e219b1f_179a9ead?usp... : PS2, Line 11: This change introduces USB port config. No need to break the line above?
https://review.coreboot.org/c/coreboot/+/83764/comment/44654036_89ae68c3?usp... : PS2, Line 12: Tested how? Put a USB storage device in each port? Did you do any speed tests?
File src/mainboard/lenovo/t520/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83764/comment/8ca4b7a3_79cdb304?usp... : PS2, Line 77: }" One indentation too much?