Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61446 )
Change subject: soc/mediatek/mt8186: Fix issue of clearing watchdog status
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61446/comment/fa0718cb_cec6a37c
PS1, Line 9: .
is wrong in CB:58835.
Done
https://review.coreboot.org/c/coreboot/+/61446/comment/d24176ea_af82e770
PS1, Line 9: Wrong implementation for
The implementation of
Done
https://review.coreboot.org/c/coreboot/+/61446/comment/408cf0d4_1e41cd60
PS1, Line 10: The setting value should be:
: value of wdt mode | 0x22000000.
The value written to the 'wdt_mode' register should be 'wdt_mode | 0x22000000' instead of 'wdt_statu […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61446
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8c5dbaab2ac43d3867037bc4160aa5af2d79284f
Gerrit-Change-Number: 61446
Gerrit-PatchSet: 2
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 07 Feb 2022 02:03:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment