[coreboot-gerrit] Change in coreboot[master]: security/vboot: Add vboot callbacks to support EC software sync

[Joel Kitching (Code Review)]

Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36208 )

Change subject: security/vboot: Add vboot callbacks to support EC software sync
......................................................................

Patch Set 2:

(3 comments)

To be honest, I'm a little bit worried that we're adding so much code here without any unit testing...

https://review.coreboot.org/c/coreboot/+/36208/2/src/security/vboot/sync_ec.... 
File src/security/vboot/sync_ec.c:

PS2: 
We might want to call this file ec_sync.c instead to be more consistent with vboot_reference naming.

https://review.coreboot.org/c/coreboot/+/36208/2/src/security/vboot/sync_ec.... 
PS2, Line 35: #define EC_PRIMARY_IDX 0
Can we just get rid of the concept of "primary" and "alternate" EC altogether?  There will only ever be one EC going forward.

https://review.coreboot.org/c/coreboot/+/36208/2/src/security/vboot/sync_ec.... 
PS2, Line 80: Flash
Probably no good reason to capitalize Flash here (and in below comments).