Attention is currently required from: Tao Xia.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56828 )
Change subject: mb/google/dedede/var/storo: Fixed iasl can not run on Dut
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56828/comment/c1f3110b_d1e1f744
PS2, Line 7: mb/google/dedede/var/storo: Fixed iasl can not run on Dut
Next time, please use imperative mood and please describe the action of the change.
[1]: https://chris.beams.io/posts/git-commit/
https://review.coreboot.org/c/coreboot/+/56828/comment/9ecb1104_80e75dd2
PS2, Line 9: The TSR1._PSV has been redefined.
When or in what commit?
https://review.coreboot.org/c/coreboot/+/56828/comment/29ad9c46_71c782af
PS2, Line 10: report errors
Please paste the error next time.
https://review.coreboot.org/c/coreboot/+/56828/comment/dfbafbc0_4374a316
PS2, Line 11: Removing
removing
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56828
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I524255c79d3c71573d122944da5058389f79d95d
Gerrit-Change-Number: 56828
Gerrit-PatchSet: 2
Gerrit-Owner: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Edward Dai
edwarddai@google.com
Gerrit-CC: Jinfang Mao
maojinfang@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-CC: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Attention: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Tue, 10 Aug 2021 06:55:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment