Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36329 )
Change subject: src/[arch-lib]: change "unsigned" to "unsigned int"
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36329/1/src/drivers/xgi/common/vb_u...
File src/drivers/xgi/common/vb_util.h:
https://review.coreboot.org/c/coreboot/+/36329/1/src/drivers/xgi/common/vb_u...
PS1, Line 22: intintlong
looks like most of these should not have the 'int's applied and leave them alone. […]
Missed this on my initial review. Checkpatch inserted the 'int' at the wrong location.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36329
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb7b48a7a144421aff29acbb7ac30968ae5fe5ab
Gerrit-Change-Number: 36329
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Sat, 26 Oct 2019 15:32:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment