Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37662 )
Change subject: soc/intel/{icl,cnl,tgl}: Always add PM1_TMR block to FADT
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37662/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37662/1//COMMIT_MSG@13
PS1, Line 13: Porting from https://review.coreboot.org/c/coreboot/+/23510/
URLs can break with time and the referenced commit is already
merged. So it would be better to use the commit hash (which can't
change anymore), e.g.
Porting from 662b6cb3ed (soc/intel/skylake: Always add PM1_TMR block to FADT).
(output of `git log -1 --format='%h (%s)' 662b6cb`)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37662
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3d592623f3a84051477ffe83a0cf0daf30dd36f
Gerrit-Change-Number: 37662
Gerrit-PatchSet: 1
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 29 Dec 2019 15:16:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment