Attention is currently required from: Suresh Bellampalli, Vanessa Eusebio, Angel Pons.
Jeff Daly has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61341 )
Change subject: [UNTESTED] mb/intel/harcuvar: Fix memory-down code
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
i *believe* that i can test this, most of our platforms have at least 1 channel that is memory down, but we have an SPD eeprom on board to make it simpler for the FSP. directing the FSP to use the memory-down spd data rather than reading the eeprom should prove this code out. Or, as Mariusz has indicated, just providing an spd.bin file (can be gotten from the DIMM manufacturer) that matches your DIMM installed and directing FSP to use that data instead would be the same.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61341
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74f0580eb05c066388fb0464658ba1228b0efe4f
Gerrit-Change-Number: 61341
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 27 Jan 2022 15:39:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment