Attention is currently required from: Robert Zieba, Raul Rangel, Jason Nien, Jon Murphy, Martin Roth, Tim Van Patten, Karthik Ramasubramanian.
Mark Hasemeyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75095 )
Change subject: mb/google/skyrim: Enable DmaProperty on WLAN device
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75095/comment/3202c715_fb1a8713
PS2, Line 10: MMIO
Can you add the bug number to these CLs?
Are we supposed to add BUG/TEST info to upstream commits? You're not supposed to for Linux kernel commits and the git history for coreboot is inconsistent here.
File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/75095/comment/3941cff3_c20b7bb1
PS2, Line 97: register "add_acpi_dma_property" = "true"
Karthik mentioned this too.
Agreed. Currently this matches the behavior of other Google mainboards, but we should evaluate all PCIe based ports.
This is being discussed on the bug. I'll cc you.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75095
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06369a19afa5b881b26f5c1eb243e2db41a9bb36
Gerrit-Change-Number: 75095
Gerrit-PatchSet: 2
Gerrit-Owner: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 10 May 2023 17:18:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Mark Hasemeyer
markhas@google.com
Gerrit-MessageType: comment