Nico Huber has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/82761?usp=email )
Change subject: console: Fix I2C/SMBus console if it's the only slow one ......................................................................
Patch Set 2:
(1 comment)
File src/include/console/console.h:
https://review.coreboot.org/c/coreboot/+/82761/comment/a972d056_3d38c721?usp... : PS1, Line 72: #define HAS_ONLY_FAST_CONSOLES !(CONFIG(SPKMODEM) || CONFIG(CONSOLE_QEMU_DEBUGCON) || \ : CONFIG(CONSOLE_SERIAL) || CONFIG(CONSOLE_NE2K) || CONFIG(CONSOLE_USB) || \ : CONFIG(EM100PRO_SPI_CONSOLE) || CONFIG(CONSOLE_SPI_FLASH) || \ : CONFIG(CONSOLE_SYSTEM76_EC) || CONFIG(CONSOLE_AMD_SIMNOW) || \ : CONFIG(CONSOLE_I2C_SMBUS))
Would it make sense to replace this with a new `HAVE_SLOW_CONSOLE` Kconfig option (or something with […]
One could still miss to select it. But I guess it would look a lot nicer :)