Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68794 )
Change subject: mb/clevo/l140mu: PECI idle workaround
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/clevo/tgl-u/variants/l140mu/gpio.c:
https://review.coreboot.org/c/coreboot/+/68794/comment/76faae9a_ec41fd0e
PS4, Line 238: pcr_rmw32(0x6b, 0x744, ~PAD_CFG1_PULL_MASK, PAD_CFG1_PULL_DN_20K);
Can this not be done inside the GPIO table itself instead of using direct PCR accesses?
no, at least not yet. This requires making the special pads available in TGL. I started looking at this, but could get that working, yet. However, since it's a workaround anways, maybe it's not that bad to be a bit more explicit here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68794
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85193000af67cd2c0465bdbb58cdd51b68fd5b4f
Gerrit-Change-Number: 68794
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Comment-Date: Sun, 30 Oct 2022 16:07:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-MessageType: comment