Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/66265 )
Change subject: superio/nuvoton/nct6687d: Fix unexpected expression ......................................................................
superio/nuvoton/nct6687d: Fix unexpected expression
Expression after a case statement are not allowed.
This fixes building with clang.
Change-Id: Ie369454f10b515aa5601a5e78330e12f4b7a5e4c Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/66265 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michał Żygowski michal.zygowski@3mdeb.com Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/superio/nuvoton/nct6687d/superio.c 1 file changed, 20 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Michał Żygowski: Looks good to me, approved
diff --git a/src/superio/nuvoton/nct6687d/superio.c b/src/superio/nuvoton/nct6687d/superio.c index 4795659..a2eea8c 100644 --- a/src/superio/nuvoton/nct6687d/superio.c +++ b/src/superio/nuvoton/nct6687d/superio.c @@ -26,14 +26,14 @@ if (!dev->enabled) return;
+ uint8_t byte; + uint8_t power_status; switch (dev->path.pnp.device) { /* TODO: Might potentially need code for EC, GPIOs, etc. */ case NCT6687D_KBC: pc_keyboard_init(PROBE_AUX_DEVICE); break; case NCT6687D_ACPI: - uint8_t byte; - uint8_t power_status; /* Set power state after power fail */ power_status = get_uint_option("power_on_after_fail", CONFIG_MAINBOARD_POWER_FAILURE_STATE);