HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36258 )
Change subject: cpu/amd/*/*/acpi/: Use 'Device()' instead of 'Processor()'
......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 3: Code-Review+2
It is odd that ACPI spec deprecated Processor but then continues to use it as examples throughout the spec. (in 14 different places)
I did not see a way to define PBlk when processors are defined as Device() objects so I assume it is not needed?
I also didn't find a way for PBLK, so I assumed that it is only needed for ACPI 1.0
I've sent an e-mail to Robert Moore asking for more information.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36258
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4541372a98f05d3e915c74bc28f41309754014e4
Gerrit-Change-Number: 36258
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 23 Oct 2019 19:22:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment