HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39907 )
Change subject: superio/winbond/{w83627hf,w83977tf}: Use macro ......................................................................
Patch Set 2:
Patch Set 2:
Have you checked that this does not change the resulting binary?
make BUILD_TIMELESS=1 gives : with current patch:
Name Offset Type Size Comp cbfs master header 0x0 cbfs header 32 none fallback/romstage 0x80 stage 16604 none cpu_microcode_blob.bin 0x41c0 microcode 83968 none fallback/ramstage 0x18a40 stage 47640 none config 0x244c0 raw 106 none revision 0x24580 raw 665 none fallback/postcar 0x24880 stage 15780 none fallback/payload 0x28680 simple elf 69336 none payload_config 0x395c0 raw 1621 none payload_revision 0x39c80 raw 235 none (empty) 0x39dc0 null 16344 none bootblock 0x3ddc0 bootblock 8192 none HOSTCC cbfstool/ifwitool.o HOSTCC cbfstool/ifwitool (link)
Built asus/p2b-d (P2B-D)
$ md5sum build/coreboot.rom cf84fe13ad961d10b6c54ed73cef33f6 build/coreboot.rom
========================================== without current patch:
Name Offset Type Size Comp cbfs master header 0x0 cbfs header 32 none fallback/romstage 0x80 stage 16604 none cpu_microcode_blob.bin 0x41c0 microcode 83968 none fallback/ramstage 0x18a40 stage 47640 none config 0x244c0 raw 106 none revision 0x24580 raw 665 none fallback/postcar 0x24880 stage 15780 none fallback/payload 0x28680 simple elf 69336 none payload_config 0x395c0 raw 1621 none payload_revision 0x39c80 raw 235 none (empty) 0x39dc0 null 16344 none bootblock 0x3ddc0 bootblock 8192 none HOSTCC cbfstool/ifwitool.o HOSTCC cbfstool/ifwitool (link)
Built asus/p2b-d (P2B-D)
$ md5sum build/coreboot.rom cf84fe13ad961d10b6c54ed73cef33f6 build/coreboot.rom
(looks like w83627hf isn't used ... yet? )