Attention is currently required from: Alexander Couzens, Paul Menzel, Valentyn Sudomyr.
Martin L Roth has posted comments on this change by Valentyn Sudomyr. ( https://review.coreboot.org/c/coreboot/+/83764?usp=email )
Change subject: mb/lenovo/t520: Add USB port config into devicetree ......................................................................
Patch Set 4: Code-Review+2
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83764/comment/2eabafda_3049f35b?usp... : PS2, Line 2: PuFF1k
If possible, it’d be great if you used your full name.
Acknowledged
https://review.coreboot.org/c/coreboot/+/83764/comment/53fd4aa4_95c23489?usp... : PS2, Line 11: This change introduces USB port config.
No need to break the line above?
Done
https://review.coreboot.org/c/coreboot/+/83764/comment/243f2a8d_e282efcd?usp... : PS2, Line 12:
Tested how? Put a USB storage device in each port? Did you do any speed tests?
Done
File src/mainboard/lenovo/t520/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83764/comment/9a57b467_58ab99bc?usp... : PS2, Line 77: }"
One indentation too much?
Done