build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59516 )
Change subject: security/intel/txt: Implement GETSEC PARAMETER dumping ......................................................................
Patch Set 1:
(4 comments)
File src/security/intel/txt/common.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133944): https://review.coreboot.org/c/coreboot/+/59516/comment/ec71beaf_24f6193b PS1, Line 446: if (eax & (1 << 7)) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133944): https://review.coreboot.org/c/coreboot/+/59516/comment/0d561a59_9bc9c836 PS1, Line 453: if (eax & (1 << 8)) { braces {} are not necessary for any arm of this statement
File src/security/intel/txt/logging.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133944): https://review.coreboot.org/c/coreboot/+/59516/comment/cf2c012e_7fd5d15c PS1, Line 253: if (txt_feature_flags & GETSEC_PARAMS_TXT_EXT_CRTM_SUPPORT) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133944): https://review.coreboot.org/c/coreboot/+/59516/comment/25a11432_01ca18a2 PS1, Line 259: if (txt_feature_flags & GETSEC_PARAMS_TXT_EXT_MACHINE_CHECK) { braces {} are not necessary for any arm of this statement