[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/xeon_sp/chip_common.c: differentiate attach_iio_stacks()

[Jonathan Zhang (Code Review)]

Attention is currently required from: Simon Chou, Johnny Lin, Christian Walter, Arthur Heymans.

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71965 )

Change subject: soc/intel/xeon_sp/chip_common.c: differentiate attach_iio_stacks()
......................................................................

Patch Set 9:

(3 comments)

File src/soc/intel/xeon_sp/chip_common.c:

https://review.coreboot.org/c/coreboot/+/71965/comment/c60f8478_3833b087 
PS2, Line 410: #if (CONFIG(SOC_INTEL_SAPPHIRERAPID_SP))
> CPP is needed here, as PlatformData struct for SPR-SP does not have Pcie64BitResourceAllocation fiel […]

Done

https://review.coreboot.org/c/coreboot/+/71965/comment/8abbee0c_f6ed8e28 
PS2, Line 495: attach_iio_stacks
> I tested on Deltalake with using the same SPR attach_iio_stacks it can boot up OS, but this function […]

Johnny, thanks for the validation. Could you submit a revision accordingly?

File src/soc/intel/xeon_sp/chip_common.c:

https://review.coreboot.org/c/coreboot/+/71965/comment/adac662c_784bf0d7 
PS8, Line 549: struct bus *nlink = dev->link_list;
             : 				while (nlink->next != NULL)
             : 					nlink = nlink->next;
             : 				nlink->next = iiostack_bus;
> There have been a lot of discussions about removing sibling busses. […]

Could we do this improvement later on?