Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44538 )
Change subject: soc/amd/picasso: Reboot for recovery if no psp workbuf is found ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44538/3/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/psp_verstage.h:
https://review.coreboot.org/c/coreboot/+/44538/3/src/soc/amd/picasso/psp_ver... PS3, Line 34: POSTCODE_CMOS_RECOVERY
Everything in this patch looks good. However, these values are for post_code(). […]
All of these postcode values that represent errors are used for both the postcode and the vboot subcode. I added a comment in the code where they're used.
Do you still want me to change anything?
https://review.coreboot.org/c/coreboot/+/44538/3/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/44538/3/src/soc/amd/picasso/psp_ver... PS3, Line 29: subcode += PSP_VBOOT_ERROR_SUBCODE; : svc_write_postcode(subcode); For all of the postcode errors, they're used as both the postcode and the bottom 8 bits of the vboot subcode.