Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31261 )
Change subject: mb/google/hatch: Replace part-specific SPD files with generic ones ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/31261/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31261/1//COMMIT_MSG@9 PS1, Line 9: can have?
https://review.coreboot.org/#/c/31261/1//COMMIT_MSG@14 PS1, Line 14: Can you please add some info as to how the common SPDs were prepared i.e. which bytes/sections are zeroed out, etc.
https://review.coreboot.org/#/c/31261/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/Makefile.inc:
https://review.coreboot.org/#/c/31261/1/src/mainboard/google/hatch/variants/... PS1, Line 16: 0 another tab to align all comments?
https://review.coreboot.org/#/c/31261/1/src/mainboard/google/hatch/variants/... PS1, Line 21: same here