Attention is currently required from: Fred Reitberger, Jason Glenesk.
Felix Held has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/83815?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/amd/*: pass PSP RPMC NVRAM base and size to amdfwtool
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/cezanne/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/83815/comment/60d8f31e_96fbc7e0?usp... :
PS2, Line 100: PSP_NVRAM_BASE
oh, this should have been PSP_RPMC_NVRAM_BASE
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83815?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id9f8a7eec68a5222be63e46173132f1c4a461b4f
Gerrit-Change-Number: 83815
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Thu, 08 Aug 2024 17:43:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No