Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47896 )
Change subject: WIP: mediatek/common/mtlib.c: Refactor mtlib_load_and_run API
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47896/10/src/soc/mediatek/common/in...
File src/soc/mediatek/common/include/soc/mtlib_common.h:
https://review.coreboot.org/c/coreboot/+/47896/10/src/soc/mediatek/common/in...
PS10, Line 6: mtlib_fw_prop
what about
struct mtlib_mcu {
const char *firmware_name;
void *run_address;
void *run_size;
void *load_buffer;
void *buffer_size;
void *priv;
void (*reset)...
}
https://review.coreboot.org/c/coreboot/+/47896/10/src/soc/mediatek/common/in...
PS10, Line 16: mtlib_load_and_run
what about call this mtlib_init_mcu?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47896
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba363483215252a5aa5ccd7f13043c0d126855f4
Gerrit-Change-Number: 47896
Gerrit-PatchSet: 10
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: tinghan shen
tinghan.shen@mediatek.com
Gerrit-Comment-Date: Fri, 04 Dec 2020 05:47:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment