Attention is currently required from: Subrata Banik.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59510 )
Change subject: soc/intel/{adl,ehl,jsl,tgl}: Remove unused header `thermal.h`
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59510/comment/4f67b481_7847713c
PS2, Line 7: Remove unused header `thermal.h`
I think the commit summary is confusing, as this change doesn't remove any files. Instead, I would've used:
Remove unnecessary `thermal.h` include
I know this change has already been submitted, but I still want to point this out for future changes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59510
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9ac0ffb352686af22cc9d11b61f904238eef278
Gerrit-Change-Number: 59510
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Mon, 22 Nov 2021 08:54:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment