[coreboot-gerrit] [S] Change in coreboot[master]: mb/google/skyrim: Disable unused SPI ROM types

[Martin Roth (Code Review)]

Attention is currently required from: Martin L Roth, Jason Nien, Jon Murphy, Tim Van Patten.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72769 )

Change subject: mb/google/skyrim: Disable unused SPI ROM types
......................................................................

Patch Set 3:

(1 comment)

File src/mainboard/google/skyrim/Kconfig:

https://review.coreboot.org/c/coreboot/+/72769/comment/b08d48f7_efeefc65 
PS3, Line 206: # Gigadevice is used on Whiterun as an alternative to Winbond
             : config SPI_FLASH_GIGADEVICE
             : 	default y
             : 
             : # XMC chips used on Markarth as an alternative to Winbond
             : # These chips identify as ST Micro (Manufacturer ID: 0x20)
             : config SPI_FLASH_STMICRO
             : 	default y
> Can these be moved to `skyrim/Kconfig. […]

While it's possible, my personal preference is that the Kconfig.name file is used only for the actual name selection. If there's a strong preference in that direction for Google platforms, I can do it, but I dislike having the board configuration being split between two files.