Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40116 )
Change subject: mb/tglrvp: Configure intel common config ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40116/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40116/2//COMMIT_MSG@8 PS2, Line 8: could you add a sentence or two about the lockdown and i2c mode setting?
https://review.coreboot.org/c/coreboot/+/40116/2/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40116/2/src/mainboard/intel/tglrvp/... PS2, Line 131: tabify indentation.
https://review.coreboot.org/c/coreboot/+/40116/2/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40116/2/src/mainboard/intel/tglrvp/... PS2, Line 124: .i2c[0] = { : .speed = I2C_SPEED_FAST, are you missing a level of indentation in these sections?