Attention is currently required from: Crystal Guo, Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85124?usp=email )
Change subject: soc/mediatek/mt8196: Reserve DRAM buffers for HW TX TRACKING
......................................................................
Patch Set 17:
(2 comments)
File src/soc/mediatek/mt8196/dramc_info.c:
https://review.coreboot.org/c/coreboot/+/85124/comment/80e70008_15f4b674?usp... :
PS17, Line 14: mc->num_entries / CHANNEL_MAX
Is it like this? […]
Yes.
Alternatively, we can use `RANK_MAX` directly and remove `rank_count`.
```
for (i = 0; i < RANK_MAX; i++) {
if (rank_size[i] == 0)
continue;
rank_size_sum += rank_size[i];
bootmem_add_range(...);
}
```
https://review.coreboot.org/c/coreboot/+/85124/comment/6cfb9709_60d973cd?usp... :
PS17, Line 24:
`* (e->channel_io_width / e->io_width)`
Also see CB:85312.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85124?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I042a74c7fbdc0d3dc19dd6bfd2bf021fe1c2b5fc
Gerrit-Change-Number: 85124
Gerrit-PatchSet: 17
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Crystal Guo
crystal.guo@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Crystal Guo
crystal.guo@mediatek.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Tue, 26 Nov 2024 02:07:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Crystal Guo
crystal.guo@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com