Attention is currently required from: Paul Menzel.
Yu-Ping Wu has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83649?usp=email )
Change subject: soc/mediatek/mt8196/memlayout: Fix the location of BOOTBLOCK comment
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Should the comment be reworded for the other SOCs too?
Yes we can reword it for mt8192 and mt8195. However this commit is mainly for moving the comment to the right location. I just took the chance to revise the comment. Therefore rewording for other SoCs can be done in separate patches IMO.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83649?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7afdf74844a9d97169b4e4a23c3c9c6060e886d9
Gerrit-Change-Number: 83649
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 26 Jul 2024 07:22:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org