[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8192: add clkbuf and srclken_rc MT6359P driver

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Joel Kitching, Roger Lu, Ran Bi, Yidi Lin, Yuchen Huang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46878 )

Change subject: soc/mediatek/mt8192: add clkbuf and srclken_rc MT6359P driver
......................................................................

Patch Set 65:

(2 comments)

File src/soc/mediatek/mt8192/srclken_rc.c:

https://review.coreboot.org/c/coreboot/+/46878/comment/3cec8886_6067b07b 
PS64, Line 365: retry--
> I suppose it's correct to use "retry--". For example, if retry=1, we will have 10us delay at least.

If retry is 1, then read32() will be called at most twice. After it fails for the second time, the value of 'retry' will be -1 (NOT 0). Therefore, another way to fix it is to change line #367 to

if (retry < 0)

Otherwise, we'll not enter the if clause.

File src/soc/mediatek/mt8192/srclken_rc.c:

https://review.coreboot.org/c/coreboot/+/46878/comment/b28fb28c_c46a1d4d 
PS65, Line 374: break
Remove it, since the if clause has been moved out of the while loop.