Enrico Granata has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31998 )
Change subject: mb/google/hatch: Add SX9310 SAR0 sensor
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31998/1/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31998/1/src/mainboard/google/hatch/variants/...
PS1, Line 240: register "reg_prox_ctrl0" = "0x10"
Are the values known good/usable?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31998
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63943cc7da5ff56f6ef6dcbd99bb8f8f031e8bf7
Gerrit-Change-Number: 31998
Gerrit-PatchSet: 1
Gerrit-Owner: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Enrico Granata
egranata@chromium.org
Gerrit-Reviewer: Enrico Granata
egranata@google.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 20 Mar 2019 20:27:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment