Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35494 )
Change subject: sc7180: initial SoC support
......................................................................
Patch Set 4:
Hi Michael,
thanks for the support.
Can you please add some documentation about the SoC to the docs/ directory?
Also a brief description of the SoC to the commit message would be good. What's kind of arm core does it use? What peripherals does it have? [..]
Best Regards,
lynxis
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35494
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iddcef560c1987486436b73ca1d5fc83cee2f713c
Gerrit-Change-Number: 35494
Gerrit-PatchSet: 4
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Wed, 25 Sep 2019 23:36:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment