Attention is currently required from: Ravi kumar, Sudheer Amrabadi.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58545 )
Change subject: sc7280: Add Modem region in memlayout to avoid modem cleanup in Secboot reboot.
......................................................................
Patch Set 15:
(1 comment)
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137365):
https://review.coreboot.org/c/coreboot/+/58545/comment/464885c9_641dda90
PS15, Line 27: if (soc_modem_carve_out(&start, &end))
that open brace { should be on the previous line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58545
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I56bfb210606b08893ff71dd1b6679f1ec102ec95
Gerrit-Change-Number: 58545
Gerrit-PatchSet: 15
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Comment-Date: Wed, 05 Jan 2022 18:08:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment