Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58306 )
Change subject: [WIP] soc/amd/common/block/uart: implement read_resource
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Furquan: since you worked on the resource allocator some months ago, I wonder if you know if a MMIO device with fixed address should have IORESOURCE_RESERVE set or not? The Intel UART uses that in the ACPI mode case which the AMD SoC UARTs always use, but the existing code for the AMD SoC I2C controllers doesn't set this flag; see the next patch. Also wouldn't it be good if the resource allocator knows all fixed MMIO regions no matter if the device is enabled or not?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58306
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ffddee3f5f4281aca98ddfcefa639dfb7a38dae
Gerrit-Change-Number: 58306
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Wed, 13 Oct 2021 18:39:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment