Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59390 )
Change subject: soc/intel/common/thermal: Drop unused parameter of pch_get_ltt_value() ......................................................................
soc/intel/common/thermal: Drop unused parameter of pch_get_ltt_value()
`struct device *dev` as part of the pch_get_ltt_value() argument is being used hence, replace with `void`.
BUG=b:193774296
Change-Id: Iecdf6f6c3023f896a27e212d7c59b2030a3fd116 Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/59390 Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/common/block/thermal/thermal.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved EricR Lai: Looks good to me, approved
diff --git a/src/soc/intel/common/block/thermal/thermal.c b/src/soc/intel/common/block/thermal/thermal.c index 11a6108..d6e401e 100644 --- a/src/soc/intel/common/block/thermal/thermal.c +++ b/src/soc/intel/common/block/thermal/thermal.c @@ -23,7 +23,7 @@ }
/* PCH Low Temp Threshold (LTT) */ -static uint32_t pch_get_ltt_value(struct device *dev) +static uint32_t pch_get_ltt_value(void) { uint8_t thermal_config;
@@ -68,6 +68,6 @@ reg16 = read16((uint16_t *)thermalbar_pm); reg16 &= ~CATASTROPHIC_TRIP_POINT_MASK; /* Low Temp Threshold (LTT) */ - reg16 |= pch_get_ltt_value(dev); + reg16 |= pch_get_ltt_value(); write16((uint16_t *)thermalbar_pm, reg16); }
4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.