Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48069 )
Change subject: mb/google/brya: Enable ACPI and add ACPI table ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48069/3/src/mainboard/google/brya/m... File src/mainboard/google/brya/mainboard.c:
https://review.coreboot.org/c/coreboot/+/48069/3/src/mainboard/google/brya/m... PS3, Line 16: static unsigned long mainboard_write_acpi_tables( : const struct device *device, unsigned long current, acpi_rsdp_t *rsdp) : { : return current; : }
Do you have a plan for using this later?
I think we can skip this function for now. This was used in the past when we had to write audio NHLT tables. But, that is not required anymore. So, it just remains unused.