Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43904 )
Change subject: cpu/intel/common: Fill cpu voltage in SMBIOS tables ......................................................................
Patch Set 5: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/43904/5/src/cpu/intel/common/Makefi... File src/cpu/intel/common/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/43904/5/src/cpu/intel/common/Makefi... PS5, Line 3: ramstage-$(CONFIG_CPU_INTEL_COMMON_HYPERTHREADING) += hyperthreading.c why do we add this line?
https://review.coreboot.org/c/coreboot/+/43904/4/src/cpu/intel/common/voltag... File src/cpu/intel/common/voltage.c:
https://review.coreboot.org/c/coreboot/+/43904/4/src/cpu/intel/common/voltag... PS4, Line 12: return (rdmsr(MSR_PERF_STATUS).hi & 0xffff) * 10 / 8192;
1.6V is expected.
Ack
https://review.coreboot.org/c/coreboot/+/43904/4/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/43904/4/src/soc/intel/common/block/... PS4, Line 3: select CPU_INTEL_COMMON_VOLTAGE
I remove this line and keep other changes. Not sure this is fine for other platform.
Ack