[coreboot-gerrit] [XS] Change in coreboot[main]: soc/amd: Ensure bank 0 is selected before accessing VBNV in CMOS

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Bao Zheng, Felix Held, Fred Reitberger, Jason Glenesk, Jérémy Compostella, Matt DeVillier, Yu-Ping Wu.

Karthik Ramasubramanian has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83495?usp=email )

Change subject: soc/amd: Ensure bank 0 is selected before accessing VBNV in CMOS
......................................................................

Patch Set 5:

(1 comment)

File src/soc/amd/common/vboot/vbnv_cmos.c:

https://review.coreboot.org/c/coreboot/+/83495/comment/f58ae2b8_0567961b?usp... :
PS4, Line 16: cmos_write(RTC_FREQ_SELECT_AMD, RTC_FREQ_SELECT);
> GOOGLE_DEWATT, GOOGLE_GUYBRUSH, GOOGLE_NIPPERKIN builds failed with "stack overlaps the previous reg […]

As I am digging about it a little bit, it seems the error is observed only with clang and not gcc. Is anything special to be done for PSP Verstage with clang?

Also the issue is happening only in MonkeyIsland and not on Zork(prior generation) or Skyrim(later generation).