Cheng-Yi Chiang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36028 )
Change subject: google/chromeos: Add a library to get DSM calibration data ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36028/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36028/4//COMMIT_MSG@13 PS4, Line 13: dsm_calib, should fix to dsm_calib_
https://review.coreboot.org/c/coreboot/+/36028/4//COMMIT_MSG@17 PS4, Line 17: "dsm_calib_r0_0"
just curious, how are those names made up and where is a global list to make sure it doesn't conflic […]
The complete list is at https://chromeos.google.com/partner/dlm/docs/factory/vpd.html The internal CL to make change to that list is at https://chrome-internal-review.googlesource.com/c/chromeos/docs/+/1983987 We are going to deprecate dsm_calib in current list because that format is bad for parsing. Beside, putting values into one field does not save the time to read VPD because there are four RT1011 devices, where we need to read once for each device.
https://review.coreboot.org/c/coreboot/+/36028/4/src/vendorcode/google/chrom... File src/vendorcode/google/chromeos/dsm_calib.c:
https://review.coreboot.org/c/coreboot/+/36028/4/src/vendorcode/google/chrom... PS4, Line 23: dsm_calib should fix to dsm_calib_