Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31725 )
Change subject: src/arch: Upgrading SMBIOS to latest version 3.2. ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/31725/2/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31725/2/src/arch/x86/smbios.c@564 PS2, Line 564: t->core_count = 0xff; that's seems wrong. the bits 31:24 contain the APIC ID.
CPUID EAX=4 and ECX=0 should be used to detect cores per package.
https://review.coreboot.org/#/c/31725/2/src/include/smbios.h File src/include/smbios.h:
https://review.coreboot.org/#/c/31725/2/src/include/smbios.h@395 PS2, Line 395: u16 core_enabled2; not sure how to detect those. Set to core_count2?
https://review.coreboot.org/#/c/31725/2/src/include/smbios.h@396 PS2, Line 396: u16 thread_count2; CPUID EAX=4 and ECX=0 should be used to detect threads per package.