Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42708 )
Change subject: AGESA fam14: Use AMD_ACPIMMIO_GPIO_BASE_100 ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42708/4/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/acpimmio_map.h:
https://review.coreboot.org/c/coreboot/+/42708/4/src/soc/amd/common/block/in... PS4, Line 36: /* Family 14h or before */ It's 100% of the discrete controller hubs, plus Kabini (Family 16h Models 00h-0Fh). Mullins (Family 16h Models 30h-3Fh) had the newer GPIO banks. And some of those discrete FCHs were also paired with Family 15h APUs.
So, I'm not sure how complex you want the comment to be. Maybe something like "All discrete FCH and f16kb".