Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45340 )
Change subject: soc/amd/picasso: Generate ACPI pstate and cstate objects in cb
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45340/7/src/soc/amd/picasso/Kconfig
File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/45340/7/src/soc/amd/picasso/Kconfig...
PS7, Line 345: AMD recommends the ACPI _PSD object to be configured to cause
: cores to transition between p-states independently. A vendor may
: choose to generate _PSD object to allow cores to transition together.
Please align the help text similar to other configs i.e. 1 tab and 2 spaces.
I didn't know initially. I updated in patch 10.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45340
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f4db3c0c2048ea1d6c6ce55f5e252cb15598514
Gerrit-Change-Number: 45340
Gerrit-PatchSet: 10
Gerrit-Owner: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 16 Sep 2020 15:44:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment